Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sender/recver builder do not set default source/target #266

Closed

Conversation

minghuaw
Copy link
Owner

@minghuaw minghuaw commented Aug 4, 2024

No description provided.

@minghuaw minghuaw self-assigned this Aug 4, 2024
@minghuaw minghuaw added the breaking This would need a breaking release label Aug 4, 2024
@minghuaw
Copy link
Owner Author

minghuaw commented Aug 4, 2024

This technically should be already achievable by manually changing the builder public field source/target to None

@minghuaw
Copy link
Owner Author

minghuaw commented Aug 6, 2024

Closing this because it's already achievable by setting the corresponding field in the builder. For example

let mut builder = Sender::builder();
builder.source = None; // This will give the source field in the Attach frame a value of None

@minghuaw minghuaw closed this Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking This would need a breaking release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant