Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework parallel util method #812

Merged
merged 2 commits into from
Aug 3, 2023
Merged

Conversation

martijn00
Copy link
Contributor

@ebozduman what about this one

@ebozduman
Copy link
Collaborator

It looks like the CRLF issue is still lingering around.

regitlint job fails with bunch of similar CRLF messages ...

error:warning: in the working copy of 'SimpleTest/Program.cs', CRLF will be replaced by LF the next time Git touches it

I thought we've fixed it for good with PR#802, provided that our setups are not going to introduce it again.

@martijn00
Copy link
Contributor Author

Weird, I did not touch any files.

@martijn00
Copy link
Contributor Author

@ebozduman Can you run this one?

@martijn00
Copy link
Contributor Author

@ebozduman this should be ready now. Can you run?

Copy link
Collaborator

@ebozduman ebozduman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@martijn00
Copy link
Contributor Author

@ebozduman not sure why the functional tests fail, it runs locally for me. Can you just run it again to see if it helps?

@ebozduman ebozduman merged commit 4528307 into minio:master Aug 3, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants