Credentials: Support assuming role via WebIdentityTokenFile #1183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saracen
force-pushed
the
web-identity-token
branch
3 times, most recently
from
8866c7d
to
50f8b85
Compare
saracen
force-pushed
the
web-identity-token
branch
from
50f8b85
to
99323bc
Compare
This supports the new AWS_WEB_IDENTITY_TOKEN_FILE and AWS_ROLE_ARN environment variables, that allow exchanging OIDC tokens given to pods in EKS for access tokens. Fixes minio#1156
harshavardhana
approved these changes
Dec 31, 2019
|
PTAL @sinhaashish @kanagarajkm |
|
Hi @harshavardhana @sinhaashish @kanagarajkm, do you have any news about this PR? It's a great feature as EKS + WebIdentity is the way to go for secure IAM credentials on AWS. |
kanagarajkm
approved these changes
Jan 7, 2020
|
Awesome, thank you |
|
Do you know when could we see it in v6.0.45 @kanagarajkm ? |
|
@jujugrrr soon no ETA |
|
thank you
…On Tue, 7 Jan 2020 at 17:17, Harshavardhana ***@***.***> wrote:
@jujugrrr <https://github.com/jujugrrr> soon no ETA
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1183?email_source=notifications&email_token=AA6ICL4KENIS3JWIMVNEVO3Q4S2J7A5CNFSM4JLPIFYKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIJTHFI#issuecomment-571683733>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA6ICL3M4BDP5LS4TYMHRCDQ4S2J7ANCNFSM4JLPIFYA>
.
|
gitlab-runner-bot
pushed a commit
to gitlabhq/gitlab-runner
that referenced
this pull request
Feb 28, 2020
Now that minio/minio-go#1183 has been merged that supports Web Identity auth in the Minio Client we need to use a recent version of Minio that includes that change that was released in v6.0.45.
This was referenced Apr 23, 2020
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This supports the new
AWS_WEB_IDENTITY_TOKEN_FILEandAWS_ROLE_ARNenvironment variables that allow exchanging OIDC tokens given to pods in EKS for access tokens.I haven't introduced any new API for this, as I figured the use-case for this will be solely EKS. So this privately extends the existing
STSWebIdentitycredential provider for AWS use and is only activated when the correct environment variables are provided. Calling NewIAM() is all that is required.I haven't actually tested this in an AWS environment yet, but figured it was worth opening for discussion early.
@barryib You requested this in #1156 - are you able to test in an AWS environment?