fix: avoid data race by copying the buffer #1357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshavardhana
force-pushed
the
fix-data-race
branch
from
60d78b9
to
9dabb50
Compare
bwplotka
added a commit
to bwplotka/minio-go
that referenced
this pull request
Mar 24, 2021
Reverted: minio#1357 Signed-off-by: Bartlomiej Plotka <[email protected]>
bwplotka
added a commit
to bwplotka/minio-go
that referenced
this pull request
Mar 24, 2021
Reverted: minio#1357 Signed-off-by: Bartlomiej Plotka <[email protected]>
|
Proposed improvement of this path: #1673. Do you have any test that reproduces this problem on latest Go version? It introduced large allocation problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1355