Do not ignore error when Instance Metadata service doesn't exist #1682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here is the description of the error: kopia/kopia#2213 (comment) |
harshavardhana
approved these changes
Jul 30, 2022
kannappanr
approved these changes
Jul 31, 2022
|
@wlan0 tests are failing, most likley tests are wrong, I don't believe your PR is causing any real regression |
|
@vadmeste I've fixed the tests |
|
This server isn't really useful because there is a required step before this server is called, which uses IMDSv2. This server will always return I'm going to update the PR to remove the |
This was referenced Aug 3, 2023
Closed
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running local tests using minio-go, where IMDS doesn't exist, ignoring this error leads to test failures.