Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added NewArnFromString to generalise the functionality of ARN parsing #1721

Merged
merged 2 commits into from
Nov 10, 2022
Merged

Added NewArnFromString to generalise the functionality of ARN parsing #1721

merged 2 commits into from
Nov 10, 2022

Conversation

vgarvardt
Copy link
Contributor

I've seen functionality like this in mc and I also need it, so decided to extract it to reusable function.

klauspost
klauspost approved these changes Nov 8, 2022
View reviewed changes
Copy link
Contributor

@klauspost klauspost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harshavardhana harshavardhana merged commit ff48c35 into minio:master Nov 10, 2022
@vgarvardt vgarvardt deleted the feature/new-arn-from-string branch November 10, 2022 15:18
@vgarvardt vgarvardt mentioned this pull request Nov 29, 2022
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klauspost klauspost klauspost approved these changes

@harshavardhana harshavardhana harshavardhana approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vgarvardt @harshavardhana @klauspost