Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Credentials module to use Assume Role API #184

Merged
merged 1 commit into from
Dec 23, 2022

Conversation

donatello
Copy link
Member

This exports a new module for retrieving STS based credentials, however they are not yet convenient to use in the library - the session token needs to be included as a custom header and may not be possible with all APIs.

krisis
krisis previously approved these changes Dec 22, 2022
Copy link
Member

@krisis krisis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except for minor comments

examples/AssumeRole.hs Outdated Show resolved Hide resolved
src/Network/Minio/Credentials.hs Outdated Show resolved Hide resolved
src/Network/Minio/Credentials.hs Outdated Show resolved Hide resolved
This exports a new module for retrieving STS based credentials, however
they are not yet convenient to use in the library - the session token
needs to be included as a custom header and may not be possible with all
APIs.
@harshavardhana harshavardhana merged commit f4ae554 into minio:master Dec 23, 2022
@donatello donatello deleted the sts-creds branch December 28, 2022 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants