Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix XML generator tests #187

Merged
merged 1 commit into from
Apr 26, 2023
Merged

Fix XML generator tests #187

merged 1 commit into from
Apr 26, 2023

Conversation

donatello
Copy link
Member

  • Differences in quoting of XML content does not impact the equality of XML docs, so we parse generated XML docs and compare for equality.

@donatello donatello requested a review from krisis April 26, 2023 17:18
@donatello
Fix XML generator tests
aa08a9a 
- Differences in quoting of XML content does not impact the equality of
XML docs, so we parse generated XML docs and compare for equality.
@donatello
Copy link
Member Author

Test failures are due to minio/minio#17084 - we can take this in.

@donatello donatello merged commit 6d3925d into minio:master Apr 26, 2023
@donatello donatello deleted the fix branch April 26, 2023 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krisis krisis krisis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@donatello @krisis