Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove final modifier from MinioClient #600

Closed
baev opened this issue Aug 16, 2017 · 0 comments
Closed

Remove final modifier from MinioClient #600

baev opened this issue Aug 16, 2017 · 0 comments
Assignees
@balamurugana
Labels
priority: medium triage
Milestone
Current

Comments

@baev
Copy link

baev commented Aug 16, 2017

It would be nice to have MinioClient non final to simplify testing for components that uses it. Currently it is not possible to create a mock of MinioClient (yeah, Mockito v2 will have kind of support for mocking final classes, but it is incubating, opt-in feature at this point)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@balamurugana balamurugana

Labels
priority: medium triage
Projects
None yet
Milestone
Current
Development

No branches or pull requests
4 participants
@balamurugana @krishnasrinivas @deekoder @baev