Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow null values for UserInfo status #1339

Closed
wants to merge 15 commits into from

Conversation

murphywill
Copy link
Contributor

LDAD users in Minio do not have a status value - it is returned as an empty string. We need to update the UserInfo class to allow for these empty string values. so we can fetch info about Minio Ldap Users.

When a user does not have a status assigned, we will get the following error:

com.fasterxml.jackson.databind.exc.ValueInstantiationException: Cannot construct instance of 'io.minio.admin.UserInfo', problem: Status must be provided

By allowing null values for the status field in the UserInfo model class, this issue is resolved.

Copy link
Member

@balamurugana balamurugana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But send single commit PR by squashing all 15 commits.

@murphywill
Copy link
Contributor Author

Replaced by #1340 - single commit PR as requested.

@murphywill murphywill closed this Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants