Close HTTP client owned by MinioClient

[findepi]

MinioClient builder and MinioAsyncClient builder allocate a new OkHttpClient instance. OkHttpClient manages internal resources such as dispatcher thread pool for executing HTTP requests and should be closed to dispose of these resources.

[balamurugana]

This breaks backward compatibility.

You would need to create another constructor and have this closeHttpClient argument and call the newly added constructor in this constructor.

Finally deprecate this constructor.

[findepi]

good catch, fixed!

[balamurugana]

Suggested change

	this.closeHttpClient = false;
	this.closeHttpClient = client.closeHttpClient;

[findepi]

That depends on the purpose of this "copy" constructor, i.e. what semantics we want,
If the caller may use both instances of S3Base, only one should close the HTTP client (and then the other is not usable anymore).
If the caller is supposed to use only the new instance of S3Base, yes, we should copy the flag.

For now, I will copy the flag.

[findepi]

@balamurugana thank you for your review!

[balamurugana]

Please fix the CI failure

[findepi]

I see this failure on the CI

Error: Exception in thread "main" io.minio.errors.ServerException: server failed with HTTP status code 500
	at io.minio.S3Base$1.onResponse(S3Base.java:753)
	at okhttp3.internal.connection.RealCall$AsyncCall.run(RealCall.kt:519)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
	at java.lang.Thread.run(Thread.java:750)

I am able to reproduce the failure locally with (following the CI script

minio-java/.github/workflows/gradle.yml

Lines 34 to 44 in fcbfa54

	- name: Set environment variables
	run: |
	echo "DEV_VERSION=$(./gradlew properties | awk '/^version:/ { print $2 }')" >> $GITHUB_ENV
	echo "RELEASE_VERSION=$(./gradlew properties -Prelease | awk '/^version:/ { print $2 }')" >> $GITHUB_ENV
	- name: Gradle build on Ununtu
	if: matrix.os == 'ubuntu-latest'
	run: |
	./gradlew build
	./gradlew runFunctionalTest
	javac -cp api/build/libs/minio-${DEV_VERSION}-all.jar functional/TestUserAgent.java
	java -Dversion=${DEV_VERSION} -cp api/build/libs/minio-${DEV_VERSION}-all.jar:functional TestUserAgent

)

./gradlew clean build && 
DEV_VERSION="$(./gradlew properties | awk '/^version:/ { print $2 }')" && 
javac -cp api/build/libs/minio-${DEV_VERSION}-all.jar functional/TestUserAgent.java &&
java -Dversion=${DEV_VERSION} -cp api/build/libs/minio-${DEV_VERSION}-all.jar:functional TestUserAgent

however, I think I am doing something wrong still, as the above fails also when I run it on master.
@balamurugana please help me what should be the right command to reproduce the CI failure

[balamurugana]

@findepi TestUserAgent.java fails due to example.org server failure. Could you apply below diff to this PR?

diff --git a/functional/TestUserAgent.java b/functional/TestUserAgent.java
index fca96cfb..51180f99 100644
--- a/functional/TestUserAgent.java
+++ b/functional/TestUserAgent.java
@@ -23,7 +23,7 @@ import java.util.Scanner;
 
 public class TestUserAgent {
   public static void main(String[] args) throws Exception {
-    MinioClient client = MinioClient.builder().endpoint("http://example.org").build();
+    MinioClient client = MinioClient.builder().endpoint("http://httpbin.org").build();
     ByteArrayOutputStream baos = new ByteArrayOutputStream();
     client.traceOn(baos);
     client.bucketExists(BucketExistsArgs.builder().bucket("any-bucket-name-works").build());

[findepi]

@balamurugana done!

[findepi]

@balamurugana thanks for review!
@harshavardhana thanks for the merge!