Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix erroneous {set,get}BucketPolicy documentation #562

Merged
merged 1 commit into from
Apr 26, 2017

Conversation

harshavardhana
Copy link
Member

No description provided.

docs/API.md Outdated
@@ -505,7 +505,7 @@ __Parameters__
|:--- |:--- |:--- |
| ``bucketName`` | _String_ | Name of the bucket. |
| ``objectPrefix`` | _String_ | Policy applies to objects with prefix. |
| ``bucketPolicy`` | _BucketPolicy_ | Policy to apply. |
| ``policy`` | _PolicyType_ | Policy to apply, available types are [NONE, READ_ONLY, READ_WRITE, WRITE_ONLY]. |
Copy link
Contributor

@nitisht nitisht Apr 23, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably it will be better to use PolicyType.NONE, PolicyType.READ_ONLY.....

Copy link
Contributor

@nitisht nitisht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except one comment.

@harshavardhana
Copy link
Member Author

Fixed can you check again @nitisht @balamurugana

@harshavardhana harshavardhana merged commit 449811a into minio:master Apr 26, 2017
@harshavardhana harshavardhana deleted the fix-docs branch April 26, 2017 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants