api: add MinioClient.ignoreCertCheck() method #572
Conversation
deekoder
requested review from
poornas,
deekoder and
harshavardhana
and removed request for
deekoder
| .build(); | ||
| } | ||
|
|
||
|
|
There was a problem hiding this comment.
Readme.md should have this publicly available method documented.
There was a problem hiding this comment.
Currently apis doing ReST calls are documented into README.md/API.md and others are covered in javadoc.
upgrading okhttp patch would have no purpose. I don't like a PR with no purpose. Do you want it in that way? |
This patch fixes below * ignoreCertCheck() enables MinioClient to ignore server certificate verification for HTTPS. * Upgrade OkHttp and Okio libraries to the latest version.
balamurugana
force-pushed
the
ignore-cert-check
branch
from
ad901e6
to
b555b5b
Compare
Yes @balamurugana if we revert this PR for some reason, it would revert the changes of migrating to okhttp3 and vice versa. So it is easier if they are separate PRs. Unless you depend on the APIs present in okhttp3 not available okhttp2 to implement ignoreCertCheck() in that case it makes sense. what do you think? |
|
Yes @balamurugana if we revert this PR for some reason, it would revert the changes of migrating to okhttp3 and vice versa. So it is easier if they are separate PRs. Unless you depend on the APIs present in okhttp3 not available okhttp2 to implement ignoreCertCheck() in that case it makes sense. what do you think? okhttp2 has a slightly different way of do that. |
Ok then i think its fine.. |
|
@poornas do you have anything to add? |
This patch fixes below
verification for HTTPS.