-
Notifications
You must be signed in to change notification settings - Fork 484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
api: add MinioClient.ignoreCertCheck() method #572
Conversation
.build(); | ||
} | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Readme.md should have this publicly available method documented.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently apis doing ReST calls are documented into README.md/API.md and others are covered in javadoc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want to upgrade okhttp in one PR and then do ignoreCertCheck method with the subsequent one?
upgrading okhttp patch would have no purpose. I don't like a PR with no purpose. Do you want it in that way? |
This patch fixes below * ignoreCertCheck() enables MinioClient to ignore server certificate verification for HTTPS. * Upgrade OkHttp and Okio libraries to the latest version.
ad901e6
to
b555b5b
Compare
Yes @balamurugana if we revert this PR for some reason, it would revert the changes of migrating to okhttp3 and vice versa. So it is easier if they are separate PRs. Unless you depend on the APIs present in okhttp3 not available okhttp2 to implement ignoreCertCheck() in that case it makes sense. what do you think? |
Yes @balamurugana if we revert this PR for some reason, it would revert the changes of migrating to okhttp3 and vice versa. So it is easier if they are separate PRs. Unless you depend on the APIs present in okhttp3 not available okhttp2 to implement ignoreCertCheck() in that case it makes sense. what do you think? okhttp2 has a slightly different way of do that. |
Ok then i think its fine.. |
@poornas do you have anything to add? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
This patch fixes below
verification for HTTPS.