fix: calculate/add MD5 hash for multiple object delete. #581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balamurugana
force-pushed
the
devel
branch
2 times, most recently
from
8812c1c
to
d9bcf6b
Compare
|
All functional tests pass with Amazon AWS S3 |
harshavardhana
requested changes
May 24, 2017
| } else if (data instanceof byte[]) { | ||
| sha256Digest.update((byte[]) data, 0, len); | ||
| } else { | ||
| throw new InternalException("unknown data to calculate SHA256 hash. This should not happend. " |
There was a problem hiding this comment.
Unknown data source to calculate sha256 hash. This should not happen, please report this issue at https://github.com/minio/minio-java/issues - is better i think.
| md5Digest.update((byte[]) data, 0, len); | ||
| } else { | ||
| throw new InternalException("unknown data to calculate SHA256 hash. This should not happend. " | ||
| + "Please report this issue at https://github.com/minio/minio-java/issues"); |
| } else if (data instanceof byte[]) { | ||
| md5Digest.update((byte[]) data, 0, len); | ||
| } else { | ||
| throw new InternalException("unknown data to calculate SHA256 hash. This should not happend. " |
| return BaseEncoding.base64().encode(md5Digest.digest()); | ||
| } | ||
|
|
||
|
|
There was a problem hiding this comment.
no. you can see double newlines between methods
poornas
requested changes
May 25, 2017
| sha256Hash = Digest.sha256Hash((RandomAccessFile) body, length); | ||
| } else if (body instanceof byte[]) { | ||
| sha256Hash = Digest.sha256Hash((byte[]) body, length); | ||
| Object data = body; |
There was a problem hiding this comment.
you might want to consider ternary operator for conciseness
Object data = (body == null) ? new byte[0] : body;
int len = (body == null) ? 0 : length;
There was a problem hiding this comment.
For this case, data and len are reset when data == null in one if seems better to me for readability sake.
There is a chance of misread two (body == null) statements.
harshavardhana
approved these changes
May 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #579