-
Notifications
You must be signed in to change notification settings - Fork 484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use chunked upload for all put object. #595
Conversation
encrypted putObject() fails with unknown reason. Debugging it. |
b4c3f46
to
6ea9652
Compare
All issues are fixed. |
Could you please fix the conflict in |
102f4cc
to
88e1df3
Compare
travis-ci fails due to its internal problem. |
oraclejdk8 failed for functional tests.
|
@harshavardhana you would need to check other runs as well. |
Travis has updated their image to trusty which doesn't ship oraclejdk7 anymore - travis-ci/travis-ci#7884 - Fix is to remove oraclejdk7 http://www.webupd8.org/2017/06/why-oracle-java-7-and-6-installers-no.html - We need to rework our .travis.yml |
Tested locally against AWS S3, tests pass. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
||
this.bytesRead++; | ||
// Return value must be between 0 to 255. | ||
return this.chunkBody[this.chunkPos++] & 0xFF; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How does this.chunkBody[this.chunkPos++]
evaluate? Does it return the value at index this.chunkPos
before the increment? Is it non-idiomatic to do the increment and indexing in separate statements?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it return the value at index this.chunkPos before the increment?
Yes. As ++
operator placed after variable, the variable is incremented after reading the value. I am breaking the statement into two for better readability
a81252d
to
2b0fa3c
Compare
Depends on #596 for travis-ci failure. |
2b0fa3c
to
aea2196
Compare
I see oraclejdk8 fails in travis-ci with below error
here, exit code denotes signal 9 killed the process (formula: 128 + signal = 137). It means OOM in linux. Not sure why OOM only on oraclejdk8. |
aea2196
to
764b69f
Compare
We might have to test it with oraclejdk8 . I don't have oraclejdk8 locally will install and check. |
7ebeb9d
to
0a9f542
Compare
Travis CI succeeded without any change in the PR |
0a9f542
to
df1d1b2
Compare
df1d1b2
to
06e844a
Compare
For more information
http://docs.aws.amazon.com/AmazonS3/latest/API/sigv4-streaming.html
Fixes #568