tests: cleanup functional tests #607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balamurugana
force-pushed
the
functional-test-cleanup
branch
4 times, most recently
from
b77772a
to
4b6bde1
Compare
kannappanr
reviewed
Sep 6, 2017
| mintFailedLog("putObject(String bucketName, String objectName, String filename, String contentType)", | ||
| "contentType: " + customContentType, startTime, null, null); | ||
| if (!customContentType.equals(objectStat.contentType())) { | ||
| throw new Exception("content type mismatch, expected: " + customContentType + ", got: " |
There was a problem hiding this comment.
Where will removeObject get called, after the exception is thrown?
There was a problem hiding this comment.
No. When no exception is thrown, below code is executed
This patch cleans up functional tests for styles and other logical errors.
balamurugana
force-pushed
the
functional-test-cleanup
branch
from
4b6bde1
to
756bf89
Compare
krishnasrinivas
approved these changes
Sep 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch cleans up functional tests for styles and other logical errors.