tests: add more checks in list buckets functional test #622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balamurugana
force-pushed
the
add-more-check-for-list-buckets
branch
2 times, most recently
from
d3bb018
to
b3f439c
Compare
kannappanr
reviewed
Oct 3, 2017
| for (Bucket bucket : client.listBuckets()) { | ||
| ignore(bucket); | ||
| if (bucket.name().equals(bucketName)) { | ||
| if (found) { |
There was a problem hiding this comment.
When would we have a duplicate entry? In what failure scenario, do you think this will happen?
There was a problem hiding this comment.
It should not happen. A buggy server may return duplicate entry so this check is added.
balamurugana
force-pushed
the
add-more-check-for-list-buckets
branch
from
b3f439c
to
f31cfdf
Compare
nitisht
approved these changes
Oct 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.