api: getObject should set range offset when its > 0 #638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
functional/FunctionalTest.java
Outdated
| */ | ||
| public static void getObject_test8() throws Exception { | ||
| if (!mintEnv) { | ||
| System.out.println("Test: getObject(String bucketName, String objectName)"); |
There was a problem hiding this comment.
please add "zero size object" at the end of the string
balamurugana
requested changes
Oct 30, 2017
There was a problem hiding this comment.
Please fix checkstyle errors
[ant:checkstyle] /home/travis/build/minio/minio-java/api/src/main/java/io/minio/MinioClient.java:1587: 'if' have incorrect indentation level 8, expected level should be 6.
[ant:checkstyle] /home/travis/build/minio/minio-java/api/src/main/java/io/minio/MinioClient.java:1588: 'if' child have incorrect indentation level 12, expected level should be 8.
[ant:checkstyle] /home/travis/build/minio/minio-java/api/src/main/java/io/minio/MinioClient.java:1589: 'if rcurly' have incorrect indentation level 8, expected level should be 6.
[ant:checkstyle] /home/travis/build/minio/minio-java/api/src/main/java/io/minio/MinioClient.java:1590: 'else' child have incorrect indentation level 12, expected level should be 8.
[ant:checkstyle] /home/travis/build/minio/minio-java/api/src/main/java/io/minio/MinioClient.java:1591: 'else rcurly' have incorrect indentation level 8, expected level should be 6.
Closed
harshavardhana
force-pushed
the
fix-getobject
branch
from
8562c56
to
7190edd
Compare
AWS S3 and Minio both return ErrInvalidRange if the object is 0 bytes and the Range header is '0-' Fixes minio#636
harshavardhana
force-pushed
the
fix-getobject
branch
from
7190edd
to
61f34cd
Compare
|
Fixed @balamurugana |
balamurugana
approved these changes
Oct 30, 2017
balamurugana
approved these changes
Oct 31, 2017
nitisht
approved these changes
Nov 1, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AWS S3 and Minio both return ErrInvalidRange if the
object is 0 bytes and the Range header is '0-'
Fixes #636