-
Notifications
You must be signed in to change notification settings - Fork 484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
api: getObject should set range offset when its > 0 #638
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. minor comment
functional/FunctionalTest.java
Outdated
*/ | ||
public static void getObject_test8() throws Exception { | ||
if (!mintEnv) { | ||
System.out.println("Test: getObject(String bucketName, String objectName)"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add "zero size object" at the end of the string
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix checkstyle errors
[ant:checkstyle] /home/travis/build/minio/minio-java/api/src/main/java/io/minio/MinioClient.java:1587: 'if' have incorrect indentation level 8, expected level should be 6.
[ant:checkstyle] /home/travis/build/minio/minio-java/api/src/main/java/io/minio/MinioClient.java:1588: 'if' child have incorrect indentation level 12, expected level should be 8.
[ant:checkstyle] /home/travis/build/minio/minio-java/api/src/main/java/io/minio/MinioClient.java:1589: 'if rcurly' have incorrect indentation level 8, expected level should be 6.
[ant:checkstyle] /home/travis/build/minio/minio-java/api/src/main/java/io/minio/MinioClient.java:1590: 'else' child have incorrect indentation level 12, expected level should be 8.
[ant:checkstyle] /home/travis/build/minio/minio-java/api/src/main/java/io/minio/MinioClient.java:1591: 'else rcurly' have incorrect indentation level 8, expected level should be 6.
8562c56
to
7190edd
Compare
AWS S3 and Minio both return ErrInvalidRange if the object is 0 bytes and the Range header is '0-' Fixes minio#636
7190edd
to
61f34cd
Compare
Fixed @balamurugana |
AWS S3 and Minio both return ErrInvalidRange if the
object is 0 bytes and the Range header is '0-'
Fixes #636