Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

translate API docs to Chinese. #644

Merged
merged 4 commits into from
Dec 8, 2017
Merged

translate API docs to Chinese. #644

merged 4 commits into from
Dec 8, 2017

Conversation

dingjs
Copy link

@dingjs dingjs commented Nov 12, 2017

  1. translate API docs to Chinese.
  2. fix a typo 525MB to 5MB in the original API doc.

2. fix a typo 525MB to 5MB in the original API doc.
Copy link
Member

@balamurugana balamurugana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except MAINTAINERS.md needs to be removed. Q project is already taking care of this.

nitisht
nitisht previously approved these changes Nov 13, 2017
Copy link
Contributor

@nitisht nitisht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Checked via Google Translate

balamurugana
balamurugana previously approved these changes Nov 13, 2017
Copy link
Member

@balamurugana balamurugana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deekoder
Copy link
Contributor

We plan to have a native speaker review this doc as well before merging.

@deekoder deekoder requested a review from yihuaf November 14, 2017 19:32
@dingjs dingjs dismissed stale reviews from balamurugana and nitisht via 9a1ab51 November 20, 2017 12:27
README_zh_CN.md Outdated
本快速入门指南将向你展示如何安装客户端SDK并执行示例java程序。有关API和示例的完整列表,请查看[Java Client API Reference](http://docs.minio.io/docs/java-client-api-reference)文档。

## 最低需求
Java 1.7或更高版本:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.8

README_zh_CN.md Outdated
@@ -0,0 +1,166 @@
# 适用于Amazon S3兼容云存储的Minio Java SDK [![Slack](https://slack.minio.io/slack?type=svg)](https://slack.minio.io)

Minio Java Client SDK提供简单的API来访问任何Amazon S3兼容的对象存储服务。
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazon S3兼容 -> 与Amazon S3兼容

README_zh_CN.md Outdated
```

## 使用gradle
```xml
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually not xml. Though this matches the original text.

README_zh_CN.md Outdated
## 快速入门示例-文件上传
本示例程序连接到一个对象存储服务,创建一个存储桶并上传一个文件到该桶中。

你需要有存储服务的三个属性才能连接到该服务。
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

属性->参数

README_zh_CN.md Outdated
| Secret Key | Secret key是你账户的密码。 |


下面的例子,我们将使用一个运行在[https://play.minio.io:9000](https://play.minio.io:9000)的免费托管的Minio服务。你可以随意使用此服务进行测试和开发。此示例中显示的访问凭据是公开的。
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

下面的例子-> 在下面的例子的中

# 贡献者指南
* Fork minio-java.
* 创建你的分支 (`$ git checkout -b my-new-feature`)。
* 敲代码,写代码...
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

敲代码,写代码 means the same thing? Just keep one of them.

__示例__


单个对象的最大大小限制在5TB。putObject在对象大于5MiB时,自动使用multiple parts方式上传。这就当上传失败时,客户端只需要上传未成功的部分即可(类似断点上传)。上传的对象使用MD5SUM签名进行完整性验证。
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这就当上传失败时 -> 这样,当上传失败时

__示例__


单个对象的最大大小限制在5TB。putObject在对象大于5MiB时,自动使用multiple parts方式上传。这就当上传失败时,客户端只需要上传未成功的部分即可(类似断点上传)。上传的对象使用MD5SUM签名进行完整性验证。
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are two putObject methods with different paramsters.And yes, the descritions are the same in the original docs.I better just delete the duplicated descrition.


`public Iterable<Result<DeleteError>> removeObject(String bucketName, Iterable<String> objectNames)`

删除多个object。
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

对象


```java
try {
// 从存储桶中删除名为myobject的未完整上传的对象。
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indentation

Copy link

@yihuaf yihuaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yihuaf
Copy link

yihuaf commented Nov 27, 2017

A quick question, if the english documentation changes, what would be the process to keep the Chinese translation in sync?

@harshavardhana
Copy link
Member

A quick question, if the english documentation changes, what would be the process to keep the Chinese translation in sync?

// cc @deekoder

@dingjs
Copy link
Author

dingjs commented Dec 3, 2017

A quick question, if the english documentation changes, what would be the process to keep the Chinese translation in sync?

I'm thinking if you guys review some pull requests,if the docs got changed,you can tell me using slack.Then I can keep the Chinese docs in sync.
Translating the docs is not the final purpose,it's a means,it's a way to let more Chinese devlopers know minio and using minio.

@deekoder
Copy link
Contributor

deekoder commented Dec 7, 2017

When we have a major release, with doc changes then i will create an issue for @dingjs and @yihuaf to help bring the content over to the translated docs.

@harshavardhana
Copy link
Member

This PR can be merged not sure why is this still blocked.

Copy link
Contributor

@nitisht nitisht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well

@deekoder deekoder removed the blocked label Dec 8, 2017
@deekoder
Copy link
Contributor

deekoder commented Dec 8, 2017

It was blocked to get @yihuaf to give the approval. So now that he has unblocked and now merging.

@deekoder deekoder merged commit 39225c6 into minio:master Dec 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants