-
Notifications
You must be signed in to change notification settings - Fork 484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
translate API docs to Chinese. #644
Conversation
dingjs
commented
Nov 12, 2017
- translate API docs to Chinese.
- fix a typo 525MB to 5MB in the original API doc.
2. fix a typo 525MB to 5MB in the original API doc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM except MAINTAINERS.md
needs to be removed. Q
project is already taking care of this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Checked via Google Translate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
We plan to have a native speaker review this doc as well before merging. |
README_zh_CN.md
Outdated
本快速入门指南将向你展示如何安装客户端SDK并执行示例java程序。有关API和示例的完整列表,请查看[Java Client API Reference](http://docs.minio.io/docs/java-client-api-reference)文档。 | ||
|
||
## 最低需求 | ||
Java 1.7或更高版本: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1.8
README_zh_CN.md
Outdated
@@ -0,0 +1,166 @@ | |||
# 适用于Amazon S3兼容云存储的Minio Java SDK [![Slack](https://slack.minio.io/slack?type=svg)](https://slack.minio.io) | |||
|
|||
Minio Java Client SDK提供简单的API来访问任何Amazon S3兼容的对象存储服务。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazon S3兼容 -> 与Amazon S3兼容
README_zh_CN.md
Outdated
``` | ||
|
||
## 使用gradle | ||
```xml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually not xml. Though this matches the original text.
README_zh_CN.md
Outdated
## 快速入门示例-文件上传 | ||
本示例程序连接到一个对象存储服务,创建一个存储桶并上传一个文件到该桶中。 | ||
|
||
你需要有存储服务的三个属性才能连接到该服务。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
属性->参数
README_zh_CN.md
Outdated
| Secret Key | Secret key是你账户的密码。 | | ||
|
||
|
||
下面的例子,我们将使用一个运行在[https://play.minio.io:9000](https://play.minio.io:9000)的免费托管的Minio服务。你可以随意使用此服务进行测试和开发。此示例中显示的访问凭据是公开的。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
下面的例子-> 在下面的例子的中
docs/zh_CN/CONTRIBUTING.md
Outdated
# 贡献者指南 | ||
* Fork minio-java. | ||
* 创建你的分支 (`$ git checkout -b my-new-feature`)。 | ||
* 敲代码,写代码... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
敲代码,写代码 means the same thing? Just keep one of them.
docs/zh_CN/API.md
Outdated
__示例__ | ||
|
||
|
||
单个对象的最大大小限制在5TB。putObject在对象大于5MiB时,自动使用multiple parts方式上传。这就当上传失败时,客户端只需要上传未成功的部分即可(类似断点上传)。上传的对象使用MD5SUM签名进行完整性验证。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这就当上传失败时 -> 这样,当上传失败时
docs/zh_CN/API.md
Outdated
__示例__ | ||
|
||
|
||
单个对象的最大大小限制在5TB。putObject在对象大于5MiB时,自动使用multiple parts方式上传。这就当上传失败时,客户端只需要上传未成功的部分即可(类似断点上传)。上传的对象使用MD5SUM签名进行完整性验证。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ditto
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are two putObject methods with different paramsters.And yes, the descritions are the same in the original docs.I better just delete the duplicated descrition.
docs/zh_CN/API.md
Outdated
|
||
`public Iterable<Result<DeleteError>> removeObject(String bucketName, Iterable<String> objectNames)` | ||
|
||
删除多个object。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
对象
docs/zh_CN/API.md
Outdated
|
||
```java | ||
try { | ||
// 从存储桶中删除名为myobject的未完整上传的对象。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
indentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
A quick question, if the english documentation changes, what would be the process to keep the Chinese translation in sync? |
// cc @deekoder |
I'm thinking if you guys review some pull requests,if the docs got changed,you can tell me using slack.Then I can keep the Chinese docs in sync. |
This PR can be merged not sure why is this still blocked. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as well
It was blocked to get @yihuaf to give the approval. So now that he has unblocked and now merging. |