-
Notifications
You must be signed in to change notification settings - Fork 484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add content negotiation #771
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sinhaashish
force-pushed
the
NonXMLResponseBody
branch
from
June 3, 2019 09:50
39b1582
to
b4b832a
Compare
@balamurugana @ebozduman PTAL |
balamurugana
reviewed
Jun 3, 2019
sinhaashish
force-pushed
the
NonXMLResponseBody
branch
from
June 10, 2019 08:36
b4b832a
to
2f3299d
Compare
sinhaashish
force-pushed
the
NonXMLResponseBody
branch
from
July 11, 2019 17:32
2f3299d
to
d70b0b4
Compare
Client only parses when the content-type of response is application/xml
sinhaashish
force-pushed
the
NonXMLResponseBody
branch
from
July 12, 2019 04:08
d70b0b4
to
98db10c
Compare
balamurugana
approved these changes
Jul 12, 2019
ebozduman
approved these changes
Jul 13, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Client only parses when the content-type of response is application/xml
Fixes #718