Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Accept-Encoding to identity by default #825

Merged
merged 5 commits into from
Jan 19, 2020

Conversation

BigUstad
Copy link
Contributor

@BigUstad BigUstad commented Dec 6, 2019

Fixes #820

Copy link
Contributor

@kannappanr kannappanr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@balamurugana balamurugana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Required to debug the issue properly to find root cause if any.

Copy link
Contributor

@kannappanr kannappanr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the check for HEAD method and simply apply this change for all the methods

@BigUstad
Copy link
Contributor Author

This change will disable default gzip compression set in okhttp3 library implementation.

@BigUstad BigUstad force-pushed the issue-820 branch 2 times, most recently from 0de2855 to a97c0b6 Compare December 17, 2019 18:40
Fixes minio#820
Override okhttp3 default encoding of gzip by explicitly setting Accept-Encoding as identity.
Copy link
Contributor

@kannappanr kannappanr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kannappanr kannappanr changed the title Resolve minio-java StatObject, nginx proxy. Set Accept-Encoding to identity by default Dec 17, 2019
@kannappanr
Copy link
Contributor

@balamurugana Can you please approve the PR?

@kannappanr kannappanr merged commit 4f3f1ef into minio:master Jan 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

StatObject issue in Java Driver
4 participants