Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add bucket encryption apis. #902

Merged
merged 1 commit into from
May 25, 2020
Merged

add bucket encryption apis. #902

merged 1 commit into from
May 25, 2020

Conversation

balamurugana
Copy link
Member

Fixes #898

@balamurugana balamurugana mentioned this pull request Apr 13, 2020
Closed
BigUstad
BigUstad previously approved these changes Apr 15, 2020
View reviewed changes
Copy link
Contributor

@BigUstad BigUstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@balamurugana balamurugana force-pushed the add-bucket-encryption-apis branch 3 times, most recently from 22cadc8 to 7ce2ae4 Compare April 27, 2020 11:21
@kannappanr
Copy link
Contributor

There should also be an example added to test the bucket encryption APIs

@balamurugana balamurugana force-pushed the add-bucket-encryption-apis branch 2 times, most recently from fcf8469 to e333ca4 Compare April 28, 2020 06:07
@balamurugana balamurugana force-pushed the add-bucket-encryption-apis branch 2 times, most recently from bec3913 to b515cf9 Compare May 6, 2020 08:08
@balamurugana balamurugana force-pushed the add-bucket-encryption-apis branch 3 times, most recently from f8d13bc to 78bf994 Compare May 14, 2020 05:21
@kannappanr
Copy link
Contributor

ping @BigUstad Can you PTAL

@balamurugana balamurugana force-pushed the add-bucket-encryption-apis branch 4 times, most recently from 5d779b8 to 6bed8fb Compare May 22, 2020 07:07
kannappanr
kannappanr previously approved these changes May 22, 2020
View reviewed changes
Copy link
Contributor

@kannappanr kannappanr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@balamurugana balamurugana force-pushed the add-bucket-encryption-apis branch 5 times, most recently from 94cc5d3 to aea0b98 Compare May 25, 2020 16:22
sinhaashish
sinhaashish approved these changes May 25, 2020
View reviewed changes
Copy link
Contributor

@sinhaashish sinhaashish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kannappanr
kannappanr approved these changes May 25, 2020
View reviewed changes
Copy link
Contributor

@kannappanr kannappanr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kannappanr kannappanr merged commit 411dfff into minio:master May 25, 2020
@balamurugana balamurugana deleted the add-bucket-encryption-apis branch May 26, 2020 06:07
BigUstad
BigUstad reviewed May 26, 2020
View reviewed changes
Copy link
Contributor

@BigUstad BigUstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BigUstad BigUstad BigUstad left review comments

@sinhaashish sinhaashish sinhaashish approved these changes

@kannappanr kannappanr kannappanr approved these changes

@nitisht nitisht Awaiting requested review from nitisht

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add put, get and delete bucket encryption configuration.
4 participants
@balamurugana @kannappanr @sinhaashish @BigUstad