Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move to simple-xml-safe #908

Merged
merged 1 commit into from
Apr 27, 2020

Conversation

balamurugana
Copy link
Member

Fixes #905

harshavardhana
harshavardhana previously approved these changes Apr 15, 2020
Copy link
Member

@harshavardhana harshavardhana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, does this break any existing releases? @balamurugana

@balamurugana
Copy link
Member Author

LGTM, does this break any existing releases? @balamurugana

No. simple-xml-safe matches with same signature of simple-xml

kannappanr
kannappanr previously approved these changes Apr 16, 2020
Copy link
Contributor

@kannappanr kannappanr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@kannappanr kannappanr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kannappanr
Copy link
Contributor

ping @harshavardhana

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CVE-2017-1000190
3 participants