Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add arg builder to {set,get,delete}BucketPolicy APIs #933

Merged
merged 1 commit into from
May 28, 2020
Merged

add arg builder to {set,get,delete}BucketPolicy APIs #933

merged 1 commit into from
May 28, 2020

Conversation

balamurugana
Copy link
Member

No description provided.

@balamurugana balamurugana changed the title add arg builder to {set,get}BucketPolicy APIs add arg builder to {set,get,delete}BucketPolicy APIs May 14, 2020
@balamurugana balamurugana force-pushed the add-arg-builder-to-set-get-BucketPolicy-APIs branch from 42be3d6 to e5b2b63 Compare May 14, 2020 12:51
@balamurugana balamurugana force-pushed the add-arg-builder-to-set-get-BucketPolicy-APIs branch 5 times, most recently from 9e830b2 to d27af9b Compare May 26, 2020 09:16
anjalshireesh
anjalshireesh requested changes May 27, 2020
View reviewed changes
Copy link
Contributor

@anjalshireesh anjalshireesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase the PR with latest master branch

api/src/main/java/io/minio/SetBucketPolicyArgs.java Show resolved Hide resolved
api/src/main/java/io/minio/MinioClient.java Outdated Show resolved Hide resolved
api/src/main/java/io/minio/MinioClient.java Show resolved Hide resolved
functional/FunctionalTest.java Show resolved Hide resolved
@balamurugana balamurugana force-pushed the add-arg-builder-to-set-get-BucketPolicy-APIs branch from d27af9b to 62a8600 Compare May 27, 2020 15:26
@balamurugana balamurugana force-pushed the add-arg-builder-to-set-get-BucketPolicy-APIs branch from 62a8600 to 259e091 Compare May 28, 2020 04:10
sinhaashish
sinhaashish approved these changes May 28, 2020
View reviewed changes
Copy link
Contributor

@sinhaashish sinhaashish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kannappanr kannappanr merged commit 19b2011 into minio:master May 28, 2020
@balamurugana balamurugana deleted the add-arg-builder-to-set-get-BucketPolicy-APIs branch May 29, 2020 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anjalshireesh anjalshireesh anjalshireesh approved these changes

@sinhaashish sinhaashish sinhaashish approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@balamurugana @anjalshireesh @sinhaashish @kannappanr