Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename getter bucketName() to bucket() in BucketArgs class. #945

Merged
merged 1 commit into from
May 18, 2020
Merged

Rename getter bucketName() to bucket() in BucketArgs class. #945

merged 1 commit into from
May 18, 2020

Conversation

balamurugana
Copy link
Member

No description provided.

@balamurugana balamurugana force-pushed the rename-getter-bucketName-to-bucket-in-BucketArgs branch from aff0ee5 to 10c3ac9 Compare May 18, 2020 10:15
anjalshireesh
anjalshireesh previously approved these changes May 18, 2020
View reviewed changes
Copy link
Contributor

@anjalshireesh anjalshireesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@balamurugana balamurugana force-pushed the rename-getter-bucketName-to-bucket-in-BucketArgs branch from 10c3ac9 to 8fcde6c Compare May 18, 2020 14:27
sinhaashish
sinhaashish approved these changes May 18, 2020
View reviewed changes
Copy link
Contributor

@sinhaashish sinhaashish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

anjalshireesh
anjalshireesh approved these changes May 18, 2020
View reviewed changes
Copy link
Contributor

@anjalshireesh anjalshireesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kannappanr kannappanr merged commit 9ba2dd1 into minio:master May 18, 2020
@balamurugana balamurugana deleted the rename-getter-bucketName-to-bucket-in-BucketArgs branch May 18, 2020 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anjalshireesh anjalshireesh anjalshireesh approved these changes

@sinhaashish sinhaashish sinhaashish approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@balamurugana @anjalshireesh @sinhaashish @kannappanr