Add arg builder to legal hold APIs #953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sinhaashish
force-pushed
the
legal-hold
branch
2 times, most recently
from
7745bfa
to
305c1f3
Compare
anjalshireesh
previously approved these changes
May 29, 2020
| @@ -4211,18 +4289,66 @@ public void disableObjectLegalHold(String bucketName, String objectName, String | |||
| * @throws NoSuchAlgorithmException thrown to indicate missing of MD5 or SHA-256 digest library. | |||
| * @throws XmlParserException thrown to indicate XML parsing error. | |||
| */ | |||
| @Deprecated | |||
There was a problem hiding this comment.
It'll be good to add the deprecation javadoc comment also along with a link to the new method to be used
sinhaashish
dismissed stale reviews from balamurugana and anjalshireesh
via
45ab095
kannappanr
approved these changes
May 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.