Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle extra headers/query params for all requests. #965

Merged
merged 1 commit into from
Jun 26, 2020
Merged

Handle extra headers/query params for all requests. #965

merged 1 commit into from
Jun 26, 2020

Conversation

balamurugana
Copy link
Member

No description provided.

@balamurugana balamurugana marked this pull request as draft June 1, 2020 13:13
@balamurugana balamurugana force-pushed the handle-extra-headers-query-params-for-all-requests branch 4 times, most recently from 4c97d32 to 7f3a50a Compare June 5, 2020 10:05
@balamurugana balamurugana force-pushed the handle-extra-headers-query-params-for-all-requests branch 2 times, most recently from f2c09b9 to 3feac57 Compare June 13, 2020 05:39
@balamurugana balamurugana force-pushed the handle-extra-headers-query-params-for-all-requests branch 5 times, most recently from b1f0d9f to 5a25dad Compare June 21, 2020 14:18
@balamurugana balamurugana marked this pull request as ready for review June 21, 2020 14:22
kannappanr
kannappanr previously approved these changes Jun 23, 2020
View reviewed changes
Copy link
Contributor

@kannappanr kannappanr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kannappanr
Copy link
Contributor

@balamurugana Please resolve the conflicts

@balamurugana balamurugana force-pushed the handle-extra-headers-query-params-for-all-requests branch from 5a25dad to 4a53033 Compare June 24, 2020 06:31
@balamurugana balamurugana force-pushed the handle-extra-headers-query-params-for-all-requests branch from 4a53033 to 5d97d8b Compare June 26, 2020 04:52
kannappanr
kannappanr approved these changes Jun 26, 2020
View reviewed changes
Copy link
Contributor

@kannappanr kannappanr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sinhaashish
sinhaashish approved these changes Jun 26, 2020
View reviewed changes
Copy link
Contributor

@sinhaashish sinhaashish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@balamurugana balamurugana merged commit 2eb9cf4 into minio:master Jun 26, 2020
@balamurugana balamurugana deleted the handle-extra-headers-query-params-for-all-requests branch June 26, 2020 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sinhaashish sinhaashish sinhaashish approved these changes

@kannappanr kannappanr kannappanr approved these changes

@anjalshireesh anjalshireesh Awaiting requested review from anjalshireesh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@balamurugana @kannappanr @sinhaashish