-
Notifications
You must be signed in to change notification settings - Fork 484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add versioning support in listObjects API #984
Add versioning support in listObjects API #984
Conversation
cc9163e
to
c480d99
Compare
c480d99
to
d8c43f1
Compare
d8c43f1
to
0644530
Compare
0644530
to
5b356a3
Compare
This enables to run almost all functional tests for verification.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested & LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a couple of minor comments
Added in the base class `ListObjectsResult` so that the implementations of `contents()` in subclasses can be simplified.
44d4abc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes #949