Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add versioning support in listObjects API #984

Merged
merged 5 commits into from
Jun 20, 2020
Merged

Add versioning support in listObjects API #984

merged 5 commits into from
Jun 20, 2020

Conversation

balamurugana
Copy link
Member

@balamurugana balamurugana commented Jun 16, 2020 •
edited
Loading

Fixes #949

@balamurugana balamurugana marked this pull request as draft June 16, 2020 16:58
@balamurugana balamurugana force-pushed the add-versioning-support-in-listObjects-API branch 3 times, most recently from cc9163e to c480d99 Compare June 17, 2020 05:12
@balamurugana balamurugana force-pushed the add-versioning-support-in-listObjects-API branch from c480d99 to d8c43f1 Compare June 17, 2020 13:03
@balamurugana balamurugana marked this pull request as ready for review June 17, 2020 13:06
@balamurugana balamurugana force-pushed the add-versioning-support-in-listObjects-API branch from d8c43f1 to 0644530 Compare June 17, 2020 17:00
@balamurugana balamurugana mentioned this pull request Jun 18, 2020
Closed
@balamurugana balamurugana force-pushed the add-versioning-support-in-listObjects-API branch from 0644530 to 5b356a3 Compare June 19, 2020 04:48
@balamurugana
Run MinIO server in distributed mode for functional tests.
fae436b 
This enables to run almost all functional tests for verification.
harshavardhana
harshavardhana previously approved these changes Jun 19, 2020
View reviewed changes
sinhaashish
sinhaashish previously approved these changes Jun 19, 2020
View reviewed changes
Copy link
Contributor

@sinhaashish sinhaashish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested & LGTM

anjalshireesh
anjalshireesh previously requested changes Jun 19, 2020
View reviewed changes
Copy link
Contributor

@anjalshireesh anjalshireesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a couple of minor comments

api/src/main/java/io/minio/messages/ListObjectsResult.java Outdated Show resolved Hide resolved
api/src/main/java/io/minio/messages/ListVersionsResult.java Outdated Show resolved Hide resolved
api/src/main/java/io/minio/messages/ListBucketResultV1.java Outdated Show resolved Hide resolved
api/src/main/java/io/minio/messages/ListBucketResultV2.java Outdated Show resolved Hide resolved
anjalshireesh and others added 2 commits June 19, 2020 19:48
@anjalshireesh @balamurugana
Add method to return empty list if null
5463dff 
Added in the base class `ListObjectsResult` so that the implementations
of `contents()` in subclasses can be simplified.
@balamurugana
use emptyIfNull() for DeleteMarker
44d4abc
anjalshireesh
anjalshireesh approved these changes Jun 20, 2020
View reviewed changes
Copy link
Contributor

@anjalshireesh anjalshireesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kannappanr kannappanr merged commit 22d3bd0 into minio:master Jun 20, 2020
@balamurugana balamurugana deleted the add-versioning-support-in-listObjects-API branch June 20, 2020 11:10
@balamurugana balamurugana mentioned this pull request Jun 20, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anjalshireesh anjalshireesh anjalshireesh approved these changes

@harshavardhana harshavardhana harshavardhana approved these changes

@sinhaashish sinhaashish sinhaashish approved these changes

@kannappanr kannappanr kannappanr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@balamurugana @anjalshireesh @harshavardhana @sinhaashish @kannappanr