Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor MinioAdminClient using HTTP client #1291

Merged
merged 27 commits into from
Nov 1, 2023

Conversation

pbrw
Copy link
Contributor

@pbrw pbrw commented Jul 25, 2023

Attempt to solve these issues #829 #1243

  • Implemented encryption/decryption of sensitive payload which is the hard part about using the HTTP Admin API
  • Refactored code to reuse the request authentication functionality
  • Implemented basic user management methods (user_add, user_remove, user_info, list_users)
  • Wrote some tests

Now it should be straightforward to implement the rest of MinIO Admin API

minio/__init__.py Outdated Show resolved Hide resolved
minio/crypto.py Show resolved Hide resolved
minio/minioadminhttp.py Outdated Show resolved Hide resolved
minio/http.py Outdated Show resolved Hide resolved
minio/helpers.py Outdated Show resolved Hide resolved
minio/error.py Outdated Show resolved Hide resolved
minio/error.py Outdated Show resolved Hide resolved
minio/datatypes.py Outdated Show resolved Hide resolved
minio/api.py Outdated Show resolved Hide resolved
@pbrw
Copy link
Contributor Author

pbrw commented Aug 21, 2023

I rewrote it according to your requests. At the moment I commented all the MinioAdmin commands with mc and I will rewrite them with HTTP in subsequent commits

@balamurugana
Copy link
Member

I rewrote it according to your requests. At the moment I commented all the MinioAdmin commands with mc and I will rewrite them with HTTP in subsequent commits

@pbrw I sent a PR pbrw#1 to your fork instead of lengthy review. Please review and merge it in your fork.

@balamurugana
Copy link
Member

@pbrw I sent you PR pbrw#3 and reverted prometheus_create() addition. Few APIs are removed and site replication APIs are added. I also increased minor version to indicate backward compatibility.

minio/minioadmin.py Outdated Show resolved Hide resolved
@balamurugana balamurugana changed the title MinIO Admin user management using HTTP Refactor MinioAdminClient using HTTP client Sep 27, 2023
@balamurugana
Copy link
Member

@pbrw Please fix CI failure

minio/minioadmin.py Outdated Show resolved Hide resolved
minio/minioadmin.py Outdated Show resolved Hide resolved
@harshavardhana harshavardhana merged commit c37956b into minio:master Nov 1, 2023
15 checks passed
@jessebot
Copy link
Contributor

how do you specify credentials now? Previously MinioAdmin took an alias.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants