Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add type hint for Minio.__init__ #1299

Merged
merged 10 commits into from
Sep 25, 2023
Merged

Conversation

trim21
Copy link
Contributor

@trim21 trim21 commented Aug 30, 2023

No description provided.

minio/api.py Show resolved Hide resolved
minio/api.py Outdated Show resolved Hide resolved
minio/api.py Outdated Show resolved Hide resolved
harshavardhana
harshavardhana previously approved these changes Sep 24, 2023
Copy link
Member

@balamurugana balamurugana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the CI failure

This reverts commit f682b61.
Copy link
Member

@balamurugana balamurugana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove all unnecessary diffs

@trim21
Copy link
Contributor Author

trim21 commented Sep 24, 2023

Remove all unnecessary diffs

already done

Copy link
Member

@balamurugana balamurugana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolve the conflict.

@harshavardhana harshavardhana merged commit 279fa11 into minio:master Sep 25, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants