MinioAdmin: Add {add,update,delete,list,get}_service_account APIs #1399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rvice_account_add
Alveel
force-pushed
the
service-accounts
branch
from
38e7b10
to
d047287
Compare
|
Ready for review! |
|
@balamurugana did you have a chance to take a peek? |
|
Some of it is not the prettiest, I welcome suggestions and improvements. |
balamurugana
requested changes
Feb 22, 2024
balamurugana
changed the title
balamurugana
approved these changes
Feb 22, 2024
harshavardhana
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the missing functions to manage service accounts with this library.
This closes #1307.