-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update mc to output new mint log format #114
Comments
Question: Do we need to make distinction between required/mandatory and optional arguments for the test case when the arguments are listed in the logs? Currently, aws-sdk-ruby provides an array of strings for
Please advise. |
I think we also need to discuss how to differentiate between the same test running with different arg values to test different scenarios, like invalid inputs etc.. At this point, |
@ebozduman I think the |
@nitisht , There was a change in the log format. You are missing "message" field. AB asked us to remove the description field and add the parameters in the function field. Here is a modified version of a sample log entry { |
I think there are couple of things I'd like to suggest/clarify and confirm with the team and AB:
|
For SDK, my recommendation is to use test method name than API name.
As we send only fields with values, I am OK with this |
@kannappanr @ebozduman @balamurugana can we have the final/consolidated log format pasted here, so it doesn't lead to rework. |
Latest Log Format.
|
The above information Kannappan put together came from an informal meeting Kannappan, AB and I had. |
Thanks @ebozduman . We can do that, but as long as this format is agreed upon and approved by @abperiasamy lets adhere to this. We'll review current PRs and implement new logging based on this format. |
mc
logs need to be updated in the format below so thatmint
logs can be easily parsed.The text was updated successfully, but these errors were encountered: