Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test for virtual host style requests #213

Closed
krishnasrinivas opened this issue Nov 7, 2017 · 2 comments · Fixed by #278
Closed

Test for virtual host style requests #213

krishnasrinivas opened this issue Nov 7, 2017 · 2 comments · Fixed by #278
Assignees
Milestone

Comments

@krishnasrinivas
Copy link

krishnasrinivas commented Nov 7, 2017

minio/minio#5095 should have mint tests.
Test can be done like this:

  • add the following entries in /etc/hosts in docker image
127.0.0.1 test.mydomain.com
127.0.0.1 mydomain.com

This is needed because if the bucket is test and endpoing is mydomain.com then the client requests will be done on the host test.mydomain.com which should be resolved to localhost (docker container itself)

  • run awscli tests with the following setting (in addition to path style tests)
aws configure set default.s3.addressing_style virtual
@krishnasrinivas
Copy link
Author

krishnasrinivas commented Nov 10, 2017

@nitisht run.sh should look like this so that it runs both path and virtual style:

#!/bin/bash
#
#  Mint (C) 2017 Minio, Inc.
#
#  Licensed under the Apache License, Version 2.0 (the "License");
#  you may not use this file except in compliance with the License.
#  You may obtain a copy of the License at
#
#      http://www.apache.org/licenses/LICENSE-2.0
#
#  Unless required by applicable law or agreed to in writing, software
#  distributed under the License is distributed on an "AS IS" BASIS,
#  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
#  See the License for the specific language governing permissions and
#  limitations under the License.
#

# handle command line arguments
if [ $# -ne 2 ]; then
    echo "usage: run.sh <OUTPUT-LOG-FILE> <ERROR-LOG-FILE>"
    exit -1
fi

output_log_file="$1"
error_log_file="$2"

# configure awscli
aws configure set aws_access_key_id "$ACCESS_KEY"
aws configure set aws_secret_access_key "$SECRET_KEY"
aws configure set default.region "$SERVER_REGION"

# run tests
endpoint="http://$SERVER_ENDPOINT"
if [ "$ENABLE_HTTPS" -eq 1 ]; then
    endpoint="https://$SERVER_ENDPOINT"
fi
./test.sh "$endpoint"  1>>"$output_log_file" 2>"$error_log_file"

aws configure set default.s3.addressing_style virtual
./test.sh "$endpoint"  1>>"$output_log_file" 2>"$error_log_file"

nitisht added a commit to nitisht/mint that referenced this issue Nov 11, 2017
Mint awscli tests now run against both path style and virtual style
if virtual style flag is set. By default only path style tests are
run

Fixes minio#213
nitisht added a commit to nitisht/mint that referenced this issue Nov 11, 2017
Mint awscli tests now run against both path style and virtual style
if virtual style flag is set. By default only path style tests are
run

Fixes minio#213
nitisht added a commit to nitisht/mint that referenced this issue Nov 17, 2017
Mint awscli tests now run against both path style and virtual style
if virtual style flag is set. By default only path style tests are
run

Fixes minio#213
nitisht added a commit to nitisht/mint that referenced this issue Nov 20, 2017
Mint awscli tests now run against both path style and virtual style
if virtual style flag is set. By default only path style tests are
run

Fixes minio#213
nitisht added a commit to nitisht/mint that referenced this issue Nov 20, 2017
Mint awscli tests now run against both path style and virtual style
if virtual style flag is set. By default only path style tests are
run

Fixes minio#213
nitisht added a commit to nitisht/mint that referenced this issue Nov 20, 2017
Mint awscli tests now run against both path style and virtual style
if virtual style flag is set. By default only path style tests are
run

Fixes minio#213
nitisht added a commit to nitisht/mint that referenced this issue Nov 20, 2017
Mint awscli tests now run against both path style and virtual style
if virtual style flag is set. By default only path style tests are
run

Fixes minio#213
@deekoder
Copy link
Contributor

@nitisht i see a bunch of commits for this issue. SHould this be closed then?

harshavardhana pushed a commit that referenced this issue Jun 28, 2018
- Add new mode to test virtual host style with awscli

Mint awscli tests now run against both path style and virtual style
if virtual style flag is set. By default only path style tests are
run

- The dnsmasq will now resolvethe wildcard entries also

This will now facilitate the randomized wildcard bucket names
in awscli tests (virtual style paths).

Fixes #213
@nitisht nitisht added the fixed label Jun 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants