Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create test directory for minio-js tests #109

Merged
merged 1 commit into from
Aug 3, 2017
Merged

Create test directory for minio-js tests #109

merged 1 commit into from
Aug 3, 2017

Conversation

nitisht
Copy link
Contributor

@nitisht nitisht commented Aug 2, 2017

Currently test directory is not created in run/core/minio-js causing npm test to fail and not run minio-js functional tests.

This PR fixes the problem.

@nitisht nitisht changed the title Create test directory for minio-js tests to run Create test directory for minio-js tests Aug 2, 2017
poornas
poornas approved these changes Aug 2, 2017
View reviewed changes
Copy link
Contributor

@poornas poornas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@nitisht nitisht merged commit 0709c98 into minio:master Aug 3, 2017
@nitisht nitisht deleted the minio-js branch August 3, 2017 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshavardhana harshavardhana harshavardhana approved these changes

@poornas poornas poornas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nitisht @harshavardhana @poornas