Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix awscli tests to fail on first error #152

Merged
merged 1 commit into from
Sep 26, 2017
Merged

Fix awscli tests to fail on first error #152

merged 1 commit into from
Sep 26, 2017

Conversation

nitisht
Copy link
Contributor

@nitisht nitisht commented Sep 26, 2017

Fixes: #147

poornas
poornas approved these changes Sep 26, 2017
View reviewed changes
Copy link
Contributor

@poornas poornas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We need to discuss whether failing on the first test failure makes sense for Mint automation.

@nitisht
Copy link
Contributor Author

nitisht commented Sep 26, 2017

We need to discuss whether failing on the first test failure makes sense for Mint automation

yes, I agree it is a testing blocker and it would be helpful to find all the failures in one go. We can take it under #151

kannappanr
kannappanr approved these changes Sep 26, 2017
View reviewed changes
Copy link
Collaborator

@kannappanr kannappanr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nitisht nitisht merged commit c02b969 into minio:master Sep 26, 2017
@nitisht nitisht deleted the awscli-log-fix branch September 26, 2017 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kannappanr kannappanr kannappanr approved these changes

@poornas poornas poornas approved these changes

@harshavardhana harshavardhana harshavardhana approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nitisht @harshavardhana @poornas @kannappanr