Remove negative test for invalid object name /2123123\123 #173
Conversation
run/core/mc/test.sh
Outdated
| @@ -517,12 +517,20 @@ function test_put_object_error() { | |||
| out="${bucket_name}" | |||
| fi | |||
|
|
|||
| # mc cp with object name //2123123\123 passes for S3 gateway as S3 allows names with \ | |||
| if [ $rv -eq 0 ]; then | |||
There was a problem hiding this comment.
Since this is a negative test case, what if the actual object creation succeeds in Minio or other backend gateway? Will we be ignoring those errors also?
There was a problem hiding this comment.
I am afraid, currently there is no way to identify server and gateway in mint and there is no plan to do this as well AFAIK..so I think we need to ignore such possibilities for now
There was a problem hiding this comment.
We had a discussion here and we feel that this a test case that we can do away with. We cannot conclusively figure out whether the client is connecting to Minio or S3-Gateway (Connecting to AWS/Minio/Azure/GCS/another Gateway) in the case awscli and mc. Since the test behavior is different in the case of Minio and AWS, it is better to remove this test case.
There was a problem hiding this comment.
@kannappanr test cases is removed
As the object name is supported on S3 and there is no way to identify server endpoint as gateway or server in Mint, we remove this specific test case Fixes minio#170
nitisht
changed the title
As discussed removed the test case
Fixes #170