Print status message based on number of tests run #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balamurugana
requested changes
Nov 4, 2017
mint.sh
Outdated
| @@ -132,7 +132,12 @@ function main() | |||
| (( i++ )) | |||
| done | |||
There was a problem hiding this comment.
You could change the above logic like i=0 then do (( i++ )) before echo -n. Later i == count for all runs and i has last executed test number
mint.sh
Outdated
| if [ $i -eq $((count + 1)) ]; then | ||
| echo -e "\nFinished running Mint. All tests run successfully" | ||
| else | ||
| echo -e "\nFinished running Mint. Executed $((i - 1)) out of $count tests." |
There was a problem hiding this comment.
IMO mint saying Mint is not clean. User knows he is running mint. I think below message is good enough $i/$count tests ran successfully where (( i-- )) if $i -ne $count
But its your call
nitisht
force-pushed
the
fix-test-message
branch
from
05aedc9
to
6397275
Compare
|
Updated @balamurugana |
nitisht
force-pushed
the
fix-test-message
branch
from
6397275
to
5cae8d7
Compare
balamurugana
approved these changes
Nov 5, 2017
poornas
approved these changes
Nov 6, 2017
|
needs rebase. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.