Add mint test to lookup directory properly #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deekoder
requested review from
donatello,
kannappanr and
poornas
and removed request for
kannappanr
harshavardhana
force-pushed
the
add-mint
branch
from
b833a1d
to
09100d7
Compare
poornas
reviewed
Nov 17, 2017
run/core/awscli/test.sh
Outdated
| log_success "$(get_duration "$start_time")" "${test_function}" | ||
| else | ||
| # clean up and log error | ||
| ${AWS} s3 rb s3://"${bucket_name}" --force > /dev/null 2>&1 |
There was a problem hiding this comment.
why remove the bucket? the next head-object test will fail
There was a problem hiding this comment.
Only under failure @poornas such a case we exit the test.
harshavardhana
force-pushed
the
add-mint
branch
from
09100d7
to
1648f62
Compare
nitisht
reviewed
Nov 17, 2017
run/core/awscli/test.sh
Outdated
| fi | ||
|
|
||
| if [ $rv -ne 0 ]; then | ||
| log_success "$(get_duration "$start_time")" "${test_function}" |
There was a problem hiding this comment.
In this case we should probably continue to next step instead of logging success. Otherwise the log has more entries than number of test cases.
There was a problem hiding this comment.
Okay that can be done.
harshavardhana
force-pushed
the
add-mint
branch
from
1648f62
to
071920f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tests for minio/minio#5179