Fix log parsing to check for lowercase fail in status #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kannappanr
requested changes
Nov 20, 2017
ebozduman
approved these changes
Nov 20, 2017
mint.sh
Outdated
| @@ -78,7 +78,7 @@ function run_test() | |||
| fi | |||
| ## Show error.log when status is empty or not "FAIL". | |||
| ## This may happen when test run failed without providing logs. | |||
| if [ "$jq_rv" -ne 0 ] || [ -z "$status" ] || [ "$status" != "FAIL" ]; then | |||
| if [ "$jq_rv" -ne 0 ] || [ -z "$status" ] || [ "$status" != "FAIL" ] && [ "$status" != "fail" ]; then | |||
There was a problem hiding this comment.
Why do we need to support lowercase "fail"? We decided to status to be a enum value than any string.
There was a problem hiding this comment.
I understand each language SDK should log the status field as an enum with only three values FAIL, PASS or NA. Few SDKs are not yet doing that (example: https://github.com/minio/mint/blob/master/run/core/aws-sdk-go/quick-tests.go#L92).
While we need to fix those SDKs, Mint should be defensive in checking these values so further such problems (status case not matching) do not report false positives.
nitisht
force-pushed
the
minio-go-logs
branch
from
225771f
to
8a70088
Compare
|
@kannappanr PR is updated, please check |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #233
While minio/minio-go#865 updates the minio-go logs to print
FAILas status instead offail, to avoid further issues, we should check for both values in Mint as well.