-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
awscli: Create directory prefix first before uploading object #236
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor comments
run/core/awscli/test.sh
Outdated
if [ $rv -eq 0 ]; then | ||
function="${AWS} s3api put-object --body ${MINT_DATA_DIR}/datafile-1-MB --bucket ${bucket_name} --key prefix/directory/datafile-1-MB" | ||
touch /tmp/zero-byte-file | ||
function="${AWS} s3api put-object --body /tmp/zero-byte-file --bucket ${bucket_name} --key prefix/directory/" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
put-object with no --body works as well. I mean ${AWS} s3api put-object --bucket ${bucket_name} --key prefix/directory/
run/core/awscli/test.sh
Outdated
else | ||
# if make_bucket fails, $bucket_name has the error output | ||
out="${bucket_name}" | ||
fi | ||
|
||
# if make bucket succeeds upload a file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comment can be updated
80429e2
to
6cb2b05
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally with S3/GCS gateway works fine
Fixes #231