Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kill tests with keyboard interruption #57

Merged
merged 1 commit into from
Jun 30, 2017
Merged

Conversation

vadmeste
Copy link
Member

Kill tests when control-c pressed, otherwise wait for tests until finishing.

Copy link
Contributor

@poornas poornas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tested....

@nitisht
Copy link
Contributor

nitisht commented Jun 30, 2017

I tried running this, looks like tests don't exit on failure. The expectation is to exit on first failure @vadmeste

@vadmeste
Copy link
Member Author

I tried running this, looks like tests don't exit on failure. The expectation is to exit on first failure @vadmeste

In my case, it works normally:

✘-255 ~/work/mint [master ↑·4|✔]
21:54 $ docker run -e SERVER_ENDPOINT=localhost:9000 -e ACCESS_KEY=minio -e SECRET_KEY=minio123 minio/mint:dev
Running awscli tests ...
aws cli run failed.

Use 'docker ps -a' to find container-id
Export run logs from the container using 'docker cp container-id:/mint/log /tmp/mint-logs'
✘-2 ~/work/mint [master ↑·4|✔]

Can you tell me how to reproduce ? @nitisht

@nitisht
Copy link
Contributor

nitisht commented Jun 30, 2017

My bad @vadmeste Looks like my local issue. it works as expected actually.

@nitisht nitisht merged commit 229644e into minio:master Jun 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants