Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate minio-py to use latest release 2.2.4 #80

Merged
merged 1 commit into from
Jul 6, 2017
+20 −405
Merged

Migrate minio-py to use latest release 2.2.4 #80

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@ FROM ubuntu:16.04

ENV DEBIAN_FRONTEND noninteractive

ENV LANG C.UTF-8

ENV GOROOT /usr/local/go

ENV GOPATH /usr/local
Expand Down
2 changes: 2 additions & 0 deletions Dockerfile.dev
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@ FROM ubuntu:16.04

ENV DEBIAN_FRONTEND noninteractive

ENV LANG C.UTF-8

ENV GOROOT /usr/local/go

ENV GOPATH /usr/local
Expand Down
3 changes: 3 additions & 0 deletions build/py/install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,9 @@ set -e
install() {
apt-get install -yq python3
apt-get install -yq python3-pip
# python3 installation doesn't create /usr/bin/python symlink,
# create this pro-actively.
update-alternatives --install /usr/bin/python python /usr/bin/python3.5 1
}

# Remove python dependencies
Expand Down
11 changes: 10 additions & 1 deletion build/py/minio-py.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,16 +19,25 @@ set -e

_init() {
MINIO_PY_SDK_PATH="/mint/run/core/minio-py"
MINIO_PY_SDK_VERSION="2.2.2"
MINIO_PY_SDK_VERSION="2.2.4"
}

installDeps() {
pip3 install --user -r ${MINIO_PY_SDK_PATH}/requirements.txt
pip3 install minio==$MINIO_PY_SDK_VERSION
}

installFunctionalTest() {
curl https://raw.githubusercontent.com/minio/minio-py/${MINIO_PY_SDK_VERSION}/tests/functional/tests.py > /usr/bin/minio-py-functional
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of curl is it a good idea to pull from a specific GitHub tag (release) so we don't get to the issue of having inconsistent tests and SDKs version.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is what its doing its picking from the tag. @nitisht

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missed that. Thanks @harshavardhana

# This is needed until we make a new minio-py release.
sed -i 's/DATA_DIR/MINT_DATA_DIR/g' /usr/bin/minio-py-functional
chmod +x /usr/bin/minio-py-functional
sync
}

main() {
installDeps
installFunctionalTest
}

_init "$@" && main
Loading