Add MarshalBinary/UnmarshalBinary support #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # sha256.go
klauspost
force-pushed
the
add-marshal-unmarshal
branch
from
c5491d0
to
df876d5
Compare
|
Can you create a new release with this fix? On 11th gen Intel CPUs which have avx512 it causes a compilation error. |
|
@SuperSandro2000 v1.0.1 released. |
Comment on lines
+414
to
+419
| if len(b) < len(magic256) || string(b[:len(magic256)]) != magic256 { | ||
| return errors.New("crypto/sha256: invalid hash state identifier") | ||
| } | ||
| if len(b) != marshaledSize { | ||
| return errors.New("crypto/sha256: invalid hash state size") | ||
| } |
There was a problem hiding this comment.
Perhaps these errors shouldn't be referencing crypto/sha256?
There was a problem hiding this comment.
Feel free to send a PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #67
Mainly copied from stdlib.