Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multiline input blocks #465

Merged
merged 7 commits into from
Mar 16, 2023
Merged

multiline input blocks #465

merged 7 commits into from
Mar 16, 2023

Conversation

miniscruff
Copy link
Owner

@miniscruff miniscruff commented Mar 13, 2023

Closes #93
Closes #385

Check the following

  • Keep 100% code coverage
  • Be properly formatted
  • Documentation changes are included
  • Include a change file if expected

Additional context
Waiting on an update from cqroot/prompt for validations.
Still need to write tests.

FYI @bephinix and @sheldonhull both of you requested this.

@trunk-io
Copy link

trunk-io bot commented Mar 13, 2023

Merging to main in this repository is managed by Trunk.

  • To merge this pull request, check the box to the left or comment /trunk merge below.

@codecov
Copy link

codecov bot commented Mar 16, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (acb805a) 100.00% compared to head (7149959) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #465   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           14        14           
  Lines         1726      1740   +14     
=========================================
+ Hits          1726      1740   +14     
Impacted Files Coverage Δ
core/config.go 100.00% <100.00%> (ø)
core/custom.go 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@miniscruff miniscruff marked this pull request as ready for review March 16, 2023 22:44
@miniscruff miniscruff merged commit 67bfae9 into main Mar 16, 2023
@miniscruff miniscruff deleted the 93-multiline-input-blocks branch March 16, 2023 22:50
@bephinix
Copy link
Contributor

@miniscruff Thx for the PR! This makes it possible for me to use Changie for even more projects. 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants