Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AP-2910: Save attachment categorisation on select #7440

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jsugarman
Copy link
Contributor

@jsugarman jsugarman commented Nov 15, 2024

What

Save attachment categorisation on select

Link to story

Categorisation would get lost if any already uploaded files were deleted
or a new file uploaded. This was due to the page being refreshed (without
being submitted) by the javascript when a new file is uploaded or existing
upload deleted.

This solution implements an immediate update of the attachment's
type/category when a categorisation is selected from the select-list.

Checklist

Before you ask people to review this PR:

  • Tests and rubocop should be passing: bundle exec rake
  • Github should not be reporting conflicts; you should have recently run git rebase main.
  • The standards in the Git Workflow document on Confluence should be followed
  • There should be no unnecessary whitespace changes. These make diffs harder to read and conflicts more likely.
  • The PR description should say what you changed and why, with a link to the JIRA story.
  • You should have looked at the diff against main and ensured that nothing unexpected is included in your changes.
  • You should have checked that the commit messages say why the change was made.

Categorisation would get lost if any already uploaded
files were deleted or a new file uploaded. This was due
to the page being refreshed by the javascript when a
new file is uploaded or existing upload deleted.

This solution implements an immediate update of the attachment's
type/category when a categorisation is selected from the select-list.
Copy link

sonarcloud bot commented Nov 15, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant