Micro-optimization of the window closing inside the shared session st…

…rategy
minkphp · Apr 10, 2024 · 21a79f7 · 21a79f7
1 parent 126c515
commit 21a79f7
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/library/aik099/PHPUnit/Session/SharedSessionStrategy.php b/library/aik099/PHPUnit/Session/SharedSessionStrategy.php
@@ -98,7 +98,7 @@ protected function stopAndForgetSession()
 	 */
 	private function _switchToMainWindow()
 	{
-		$this->_session->switchToWindow();
+		$this->_session->switchToWindow(); // Switch to the window before attempting to execute any window-based calls.
 		$actual_initial_window_name = $this->_session->getWindowName(); // Account for initial window rename.
 
 		foreach ( $this->_session->getWindowNames() as $name ) {
@@ -108,8 +108,9 @@ private function _switchToMainWindow()
 
 			$this->_session->switchToWindow($name);
 			$this->_session->executeScript('window.close();');
-			$this->_session->switchToWindow();
 		}
+
+		$this->_session->switchToWindow();
 	}
 
 	/**