Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add k8s CA file support. #136

Merged
merged 2 commits into from
Jun 23, 2020
Merged

Add k8s CA file support. #136

merged 2 commits into from
Jun 23, 2020

Conversation

p37ruh4
Copy link
Contributor

@p37ruh4 p37ruh4 commented Jun 23, 2020

Adds k8s CA file support to be able to read K8S CA certificates from local files.

@p37ruh4
Copy link
Contributor Author

p37ruh4 commented Jun 23, 2020

Resolves #135

primeroz
primeroz approved these changes Jun 23, 2020
View reviewed changes
Copy link
Contributor

@primeroz primeroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nabadger Looks good to me.

@nabadger
Copy link
Contributor

Thanks @p37ruh4

@nabadger nabadger merged commit 1303e57 into mintel:master Jun 23, 2020
@p37ruh4 p37ruh4 deleted the add-k8s-ca-file-support branch June 23, 2020 10:00
@p37ruh4
Copy link
Contributor Author

p37ruh4 commented Jun 23, 2020

@primeroz & @nabadger, thanks for reviewing and merging. Any plans on next stable release?

@p37ruh4 p37ruh4 mentioned this pull request Jun 23, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@primeroz primeroz primeroz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@p37ruh4 @nabadger @primeroz