Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Windows tab commands #86

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

lightnet328
Copy link
Contributor

The commands listed in the Windows tab do not actually work on Windows.
I fixed it.

Copy link
Contributor

@nabadger nabadger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@whereisaaron wondering if you have any comments on this PR?

I'm not familiar with powershell personally - but do the current Windows commands work for you, and would this PR break functionality for you?

I can have some co-workers test this next week (just don't want to break anything for existing users of this).

templates.go Show resolved Hide resolved
@nabadger
Copy link
Contributor

nabadger commented Feb 14, 2019

@lightnet328 thanks - Since I'm not familiar with Windows/Powershell, I'm going to run this PR by a few of our users/devs who run Windows to make sure it still works for them too.

Thanks!

templates.go Outdated Show resolved Hide resolved
@lightnet328
Copy link
Contributor Author

I used cmd.exe on Windows 10 to check the behavior of the command before and after the modification.

Copy link

@Tomvl117 Tomvl117 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why %USERPROFILE% instead of $env:UserProfile? PowerShell only seems to accept the latter for me.

@TomasKohout
Copy link

Hi guys,

could you merge this into the master and release it, please? Our users complain that Windows setup do not work properly and since this PR exists I won't create my own.

Best regards
Tom

@marians
Copy link

marians commented Jan 11, 2022

Hi! We have a few Windows users running into this problem and would be happy if the PR could get merged.

An additional problem is that Windows users have two shells in general: cmd.exe and PowerShell. Knowing which one is supposed to work (here: cmd.exe) would help remove the guesswork.

@anvddriesch
Copy link

Hey,
What is the process on this PR? Is there something we can do to help getting this merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants