Minor changes #1840
Merged
Minor changes #1840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ImplOfAnImpl
requested review from
erubboli,
azarovh and
OBorce
as code owners
ImplOfAnImpl
force-pushed
the
appease_clippy
branch
from
94698e7
to
9021605
Compare
azarovh
approved these changes
Nov 14, 2024
OBorce
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vec::with_capacityin certain places, this comes from PR use Vec::with_capacity avoid realloc memory #1831. Though I omitted changes in tests, which are redundant IMO.P.S. I had to update the rust version to 1.82, because the old and the new clippy disagree with each other.