Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: header navigation fixes #571

Merged
merged 13 commits into from
Sep 17, 2024
Merged

fix: header navigation fixes #571

merged 13 commits into from
Sep 17, 2024

Conversation

HeleenSG
Copy link
Contributor

@HeleenSG HeleenSG commented Jul 5, 2024

Changes

  • Fixes icon-only elements within header navigations.
  • Adds button mixins for consistency and easier implementation of buttons within other components.
  • Adds header example with search field (and form)
  • Fixes button states (like focus, hover and active state)

This pr doesn't upgrade all components that use buttons yet. As we've decided to create separate pr's for that to keep this pr manageable.

Demo

/components/header-navigation/example-search
Screenshot 2024-09-06 at 12 23 34

Ticket

Closes #561

QA Notes

Please check if:

  • There is any weird/unexpected styling behaviour or regressions
  • Mixins are set up nicely and follow a logical flow
  • Documentation has been properly updated (with correct html examples)

Known issue

  • Sometimes the rendering of the page specific styling doesn't work as expected. Resulting in a loss of space between the input field and the tab navigation items. We've looked into this. It's a issue specific to the way the docs are set up and not an issue with the css itself. We're looking to improve the way we show examples for html-components that have a specific place in the page (like a header). So we can remove the need for page specific styling within the docs. For now refresh the page it should show the correct css. We will solve this issue in a separate pr as it is out of scope for this ticket.

Copy link

sonarcloud bot commented Jul 5, 2024

@HeleenSG HeleenSG self-assigned this Aug 21, 2024
@HeleenSG HeleenSG added the bug Something isn't working label Sep 6, 2024
@HeleenSG HeleenSG marked this pull request as ready for review September 6, 2024 11:18
@HeleenSG HeleenSG requested a review from a team as a code owner September 6, 2024 11:18
ppvg
ppvg previously approved these changes Sep 17, 2024
Copy link
Contributor Author

@HeleenSG HeleenSG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed @ppvg's changes. Approved.

jpbruinsslot
jpbruinsslot previously approved these changes Sep 17, 2024
Copy link
Contributor

@jpbruinsslot jpbruinsslot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

both @HeleenSG and @ppvg have checked each other's work and I approve this pr on behalf of them

reinschaap
reinschaap previously approved these changes Sep 17, 2024
@reinschaap
Copy link
Contributor

I was able to test it today, good work

Copy link
Member

@ppvg ppvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@HeleenSG HeleenSG merged commit d2d60f1 into main Sep 17, 2024
9 checks passed
@HeleenSG HeleenSG deleted the fix/heading-examples branch September 17, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate search input field (icon-only) in header nav
4 participants